Remove requesting_frame parameters from Geolocation stack

Remove requesting_frame parameters from Geolocation stack

This CL removes requesting_frame parameters from the Geolocation
stack because the URL passed around in these is no longer used for
anything.

BUG=123815
TEST=unit_tests, browser_tests *Geolocation*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133183

[bartfab (slow), 2012-04-17 14:05:27]

Hi John,

could you please review this CL?

[bartfab (slow), 2012-04-19 19:24:46]

Hi John,

I think my first review request got lost because I mistyped your e-mail. Could
you have a look at this CL? Thanks.

[John Knottenbelt, 2012-04-20 09:40:37]

Looks great, thanks for doing this! Just one inline comment.

https://chromiumcodereview.appspot.com/10107017/diff/1/content/browser/geoloc...
File content/browser/geolocation/geolocation_provider.cc (right):

https://chromiumcodereview.appspot.com/10107017/diff/1/content/browser/geoloc...
content/browser/geolocation/geolocation_provider.cc:96: is_permission_granted_ =
true;
is_permission_granted_ needs to be initialised to false, probably in the
constructor.

[bartfab (slow), 2012-04-20 09:44:28]

Comment addressed.

https://chromiumcodereview.appspot.com/10107017/diff/1/content/browser/geoloc...
File content/browser/geolocation/geolocation_provider.cc (right):

https://chromiumcodereview.appspot.com/10107017/diff/1/content/browser/geoloc...
content/browser/geolocation/geolocation_provider.cc:96: is_permission_granted_ =
true;
On 2012/04/20 09:40:37, John Knottenbelt wrote:
> is_permission_granted_ needs to be initialised to false, probably in the
> constructor.

Done.

[commit-bot: I haz the power, 2012-04-20 09:54:17]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bartfab (slow), 2012-04-20 10:00:14]

John: could you express your approval of this CL using the four magic letters
required please? :)

[John Knottenbelt, 2012-04-20 10:59:34]

lgtm

Thanks again!

[commit-bot: I haz the power, 2012-04-20 10:59:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/10107017/6001

[commit-bot: I haz the power, 2012-04-20 12:42:52]

Change committed as 133183