Issue 10107002: TabContents -> WebContentsImpl, part 18.

Issue 10107002: TabContents -> WebContentsImpl, part 18. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TabContents -> WebContentsImpl, part 18. TabContents -> WebContents in chrome/, part 2. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132568

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -79 lines)			Patch
M	chrome/browser/history/history.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/history/history_tab_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/text_database_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/infobars/infobar_delegate.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.h	View	7 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/instant/instant_delegate.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.h	View	5 chunks	+16 lines, -15 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/instant/instant_loader_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/instant/instant_unload_handler.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/memory_details.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/oom_priority_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/oom_priority_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_manager_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/prerender/prerender_manager.h	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/prerender/prerender_manager.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_tab_helper.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10107002/1

8 years, 8 months ago (2012-04-17 13:18:45 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-17 13:18:58 UTC) #4

Presubmit check for 10107002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/history

Presubmit checks took 2.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages