chrome/browser/instant/instant_loader.cc - Issue 10107002: TabContents -> WebContentsImpl, part 18.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_loader.cc

Issue 10107002: TabContents -> WebContentsImpl, part 18. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/instant/instant_loader.cc

diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc

index dce93492bf51bf74b18f3fa31717bd73fd6aa6a3..d280bcb03e67c44bfd110b915bfc8a7ca21ba43d 100644

--- a/chrome/browser/instant/instant_loader.cc

+++ b/chrome/browser/instant/instant_loader.cc

@@ -641,8 +641,8 @@ InstantLoader::InstantLoader(InstantLoaderDelegate* delegate,

InstantLoader::~InstantLoader() {

registrar_.RemoveAll();

- // Delete the TabContents before the delegate as the TabContents holds a

- // reference to the delegate.

+ // Delete the TabContentsWrapper before the delegate as the TabContentsWrapper

+ // holds a reference to the delegate.

if (preview_contents())

AddPreviewUsageForHistogram(template_url_id_, PREVIEW_DELETED, group_);

preview_contents_.reset();