Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10105030: TabContents -> WebContentsImpl, part 21. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, yoshiki+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 21. TabContents -> WebContents in chrome/, part 4. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -213 lines) Patch
M chrome/browser/tabs/tab_strip_model.h View 18 chunks +78 lines, -74 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_delegate.h View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_observer.h View 3 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator.h View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 5 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/js_modal_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-17 15:16:21 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-17 19:57:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10105030/1
8 years, 8 months ago (2012-04-17 20:01:43 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 20:02:02 UTC) #4 
Presubmit check for 10105030-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui
    chrome/browser/tabs

Presubmit checks took 3.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698