Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10103023: Breaks logout on retail mode. (Closed)

Created:
8 years, 8 months ago by rkc
Modified:
8 years, 8 months ago
Reviewers:
rkc
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Breaks logout on retail mode. Revert 131704 - Use ExitCleanly to exit intead of AttemptUserExit. When the idle logout dialog exits, it needs to completely just exit the browser and not get blocked by any existing windows waiting to close; hence use ExitCleanly instead of AttemptUserExit when ending the session from the idle logout dialog. R=tbarzic@chromium.org BUG=chromium-os:29176 TEST=Tested that we logout instead of getting stuck. Review URL: https://chromiumcodereview.appspot.com/10014036 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
rkc
8 years, 8 months ago (2012-04-17 04:01:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698