Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10014036: Use ExitCleanly to exit intead of AttemptUserExit. (Closed)

Created:
8 years, 8 months ago by rkc
Modified:
8 years, 8 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use ExitCleanly to exit intead of AttemptUserExit. When the idle logout dialog exits, it needs to completely just exit the browser and not get blocked by any existing windows waiting to close; hence use ExitCleanly instead of AttemptUserExit when ending the session from the idle logout dialog. R=tbarzic@chromium.org BUG=chromium-os:29176 TEST=Tested that we logout instead of getting stuck. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rkc
8 years, 8 months ago (2012-04-10 22:31:41 UTC) #1
tbarzic
On 2012/04/10 22:31:41, Rahul Chaturvedi wrote: lgtm
8 years, 8 months ago (2012-04-10 22:58:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10014036/1
8 years, 8 months ago (2012-04-10 23:09:09 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-11 00:02:24 UTC) #4
Try job failure for 10014036-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698