Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issue 10103022: Revert 132517 - Metro/HiDPI: Move 1x icons into separate pak file (Closed)

Created:
8 years, 8 months ago by Hironori Bono
Modified:
8 years, 8 months ago
Reviewers:
sail
CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 132517 - Metro/HiDPI: Move 1x icons into separate pak file Currently all 1x art files are repacked into chrome.pak files. This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale. As a first step this CL does the following: - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome. - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak - update the Mac and Windows installer code to package the extra pak files. Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation. BUG=114311 TEST=Ran on Windows, and Mac and Linux. Review URL: http://codereview.chromium.org/10024050 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -184 lines) Patch
M build/common.gypi View 6 chunks +0 lines, -14 lines 0 comments Download
M chrome/chrome_dll.gypi View 4 chunks +8 lines, -10 lines 0 comments Download
M chrome/chrome_repack_chrome.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/chrome_repack_theme_resources_2x.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/tools/build/win/release.rules View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +5 lines, -14 lines 0 comments Download
M ui/base/resource/resource_bundle_linux.cc View 1 chunk +3 lines, -14 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 chunk +1 line, -11 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M ui/base/ui_base_paths.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/base/ui_base_paths.cc View 2 chunks +11 lines, -1 line 0 comments Download
M ui/test/test_suite.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
8 years, 8 months ago (2012-04-17 04:00:24 UTC) #1
Hironori Bono
8 years, 8 months ago (2012-04-17 04:04:48 UTC) #2
Greetings,

Unfortunately, I have reverted your change because it caused a builder break on
the "win" builder. Would it be possible to test your next change with a clobber
build ('gcl try -c')?

(*1) http://chromegw.corp.google.com/i/chromium/builders/Win/builds/10439

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698