Remove Debug object from the user roots in heap profiler.

Remove Debug object from the user roots in heap profiler.

Committed: https://code.google.com/p/v8/source/detail?r=11358

[yurys, 2012-04-16 17:44:15]

Can we test this?

https://chromiumcodereview.appspot.com/10096016/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10096016/diff/1/src/profile-generator....
src/profile-generator.cc:1996: false;
You could initialize is_debug_object with false and put all the logic behind the
guard.

[mnaganov (inactive), 2012-04-16 19:55:29]

I would also like to have a test

[alexeif, 2012-04-17 13:43:00]

https://chromiumcodereview.appspot.com/10096016/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10096016/diff/1/src/profile-generator....
src/profile-generator.cc:1996: false;
On 2012/04/16 17:44:15, Yury Semikhatsky wrote:
> You could initialize is_debug_object with false and put all the logic behind
the
> guard.

Done.

[mnaganov (inactive), 2012-04-17 14:16:14]

https://chromiumcodereview.appspot.com/10096016/diff/4001/src/profile-generat...
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10096016/diff/4001/src/profile-generat...
src/profile-generator.h:1129: bool IsWindowReference(const HeapGraphEdge& edge);
-> IsUserGlobalReference?

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1576: int count_globals = 0;
nit: globals_count sounds more appropriate

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1579: if (edge->GetType() ==
v8::HeapGraphEdge::kShortcut) {
Perhaps, expose IsWindowReference to public and use it here?

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1581: const v8::HeapGraphNode* global =
edge->GetToNode();
You can use "GetProperty" helper function defined in this file.

[alexeif, 2012-04-17 15:30:09]

https://chromiumcodereview.appspot.com/10096016/diff/4001/src/profile-generat...
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10096016/diff/4001/src/profile-generat...
src/profile-generator.h:1129: bool IsWindowReference(const HeapGraphEdge& edge);
On 2012/04/17 14:16:14, Mikhail Naganov (Chromium) wrote:
> -> IsUserGlobalReference?

Done.

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1576: int count_globals = 0;
On 2012/04/17 14:16:14, Mikhail Naganov (Chromium) wrote:
> nit: globals_count sounds more appropriate

Done.

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1579: if (edge->GetType() ==
v8::HeapGraphEdge::kShortcut) {
On 2012/04/17 14:16:14, Mikhail Naganov (Chromium) wrote:
> Perhaps, expose IsWindowReference to public and use it here?
I don't think we need to make it public.

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1581: const v8::HeapGraphNode* global =
edge->GetToNode();
On 2012/04/17 14:16:14, Mikhail Naganov (Chromium) wrote:
> You can use "GetProperty" helper function defined in this file.
I don't know the name of the user global.

[mnaganov (inactive), 2012-04-17 15:35:51]

LGTM

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10096016/diff/4001/test/cctest/test-he...
test/cctest/test-heap-profiler.cc:1581: const v8::HeapGraphNode* global =
edge->GetToNode();
On 2012/04/17 15:30:10, alexeif wrote:
> On 2012/04/17 14:16:14, Mikhail Naganov (Chromium) wrote:
> > You can use "GetProperty" helper function defined in this file.
> I don't know the name of the user global.

Sorry, I have misread your code.