Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/profile-generator.h

Issue 10096016: Remove Debug object from the user roots in heap profiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 71167f735810749ac8da45bed21b28e8a0fed53a..e4340a516a488ca9406de1005cc63b8ccc5fdc7b 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -563,8 +563,8 @@ class HeapEntry BASE_EMBEDDED {
void clear_paint() { painted_ = false; }
bool painted() { return painted_; }
void paint() { painted_ = true; }
- bool reachable_from_window() { return reachable_from_window_; }
- void set_reachable_from_window() { reachable_from_window_ = true; }
+ bool user_reachable() { return user_reachable_; }
+ void set_user_reachable() { user_reachable_ = true; }
void SetIndexedReference(HeapGraphEdge::Type type,
int child_index,
@@ -601,7 +601,7 @@ class HeapEntry BASE_EMBEDDED {
const char* TypeAsString();
unsigned painted_: 1;
- unsigned reachable_from_window_: 1;
+ unsigned user_reachable_: 1;
unsigned type_: 4;
int children_count_: 26;
int retainers_count_;
@@ -1021,7 +1021,7 @@ class V8HeapExplorer : public HeapEntriesAllocator {
HeapEntry* parent,
String* reference_name,
Object* child);
- void SetWindowReference(Object* window);
+ void SetUserGlobalReference(Object* window);
void SetRootGcRootsReference();
void SetGcRootsReference(VisitorSynchronization::SyncTag tag);
void SetGcSubrootReference(
@@ -1126,8 +1126,8 @@ class HeapSnapshotGenerator : public SnapshottingProgressReportingInterface {
bool CountEntriesAndReferences();
bool FillReferences();
void FillPostorderIndexes(Vector<HeapEntry*>* entries);
- bool IsWindowReference(const HeapGraphEdge& edge);
- void MarkWindowReachableObjects();
+ bool IsUserGlobalReference(const HeapGraphEdge& edge);
+ void MarkUserReachableObjects();
void ProgressStep();
bool ProgressReport(bool force = false);
bool SetEntriesDominators();
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698