Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 10086027: Revert 132312 - Proper fix for https://chromiumcodereview.appspot.com/10073005 : (Closed)

Created:
8 years, 8 months ago by eroman
Modified:
8 years, 8 months ago
Reviewers:
zel
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 132312 - Proper fix for https://chromiumcodereview.appspot.com/10073005 : ----------------- Reason: build failure on Chromiumos Clang ----------------- In file included from chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:27: ./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:17:3:error: [chromium-style] Complex constructor has an inlined body. MockDirectoryChangeObserver() {} ^ ./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:18:3:error: [chromium-style] Complex destructor has an inline body. virtual ~MockDirectoryChangeObserver() {} ^ 2 errors generated. ----------------- gdata: Remove OnDirectoryChanged from MockGDataSyncClient, added MockDirectoryChangeObserver for directory change notifications. BUG=none TEST=existing GDataFileSystemTest.* Review URL: http://codereview.chromium.org/10081032 TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -57 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 18 chunks +26 lines, -30 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_directory_change_observer.h View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_gdata_sync_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eroman
8 years, 8 months ago (2012-04-14 02:43:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698