gdata: Remove OnDirectoryChanged from MockGDataSyncClient

gdata: Remove OnDirectoryChanged from MockGDataSyncClient

It's wrong to have OnDirectoryChanged in MockGDataSyncClient,
as GDataSyncClient is not interested in the event.

BUG=none
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132149

[Jun Mukai, 2012-04-13 06:06:59]

lgtm

[zel, 2012-04-13 17:57:49]

Why did you do this? You have just nuked all directory notification tests that
we had there.

The correct fix would be to create another mock that is interested in
OnDirectoryChanged() event only, not to remove all tests.

I am going to revert this CL.

[satorux1, 2012-04-14 03:04:22]

Sorry about that. I thought these were there just to suppress mock warnings
than to be intentionally placed as the sync client is not interested in the
event. I should not have touched code in the midnight before going on
vacation. :~(

Now going back to pretend I'm offline...

On Apr 13, 2012 7:57 AM, <zelidrag@chromium.org> wrote:

> Why did you do this? You have just nuked all directory notification tests
that
> we had there.

> The correct fix would be to create another mock that is interested in
> OnDirectoryChanged() event only, not to remove all tests.

> I am going to revert this CL.

> https://chromiumcodereview.appspot.com/10073005/

[zel, 2012-04-14 03:26:42]

no problem, i am trying to re-land the proper fix at
http://codereview.chromium.org/10081032/


On Fri, Apr 13, 2012 at 8:04 PM, Satoru Takabayashi <satorux@chromium.org>wrote:

> Sorry about that. I thought these were there just to suppress mock
> warnings than to be intentionally placed as the sync client is not
> interested in the event. I should not have touched code in the midnight
> before going on vacation. :~(
>
> Now going back to pretend I'm offline...
>
> On Apr 13, 2012 7:57 AM, <zelidrag@chromium.org> wrote:
> >
> > Why did you do this? You have just nuked all directory notification
> tests that
> > we had there.
> >
> > The correct fix would be to create another mock that is interested in
> > OnDirectoryChanged() event only, not to remove all tests.
> >
> > I am going to revert this CL.
> >
> > https://chromiumcodereview.appspot.com/10073005/
>

[zel, 2012-04-14 03:55:27]

landed from the second attempt


On Fri, Apr 13, 2012 at 8:26 PM, Zelidrag Hornung <zelidrag@chromium.org>wrote:

> no problem, i am trying to re-land the proper fix at
> http://codereview.chromium.org/10081032/
>
>
>
> On Fri, Apr 13, 2012 at 8:04 PM, Satoru Takabayashi
<satorux@chromium.org>wrote:
>
>> Sorry about that. I thought these were there just to suppress mock
>> warnings than to be intentionally placed as the sync client is not
>> interested in the event. I should not have touched code in the midnight
>> before going on vacation. :~(
>>
>> Now going back to pretend I'm offline...
>>
>> On Apr 13, 2012 7:57 AM, <zelidrag@chromium.org> wrote:
>> >
>> > Why did you do this? You have just nuked all directory notification
>> tests that
>> > we had there.
>> >
>> > The correct fix would be to create another mock that is interested in
>> > OnDirectoryChanged() event only, not to remove all tests.
>> >
>> > I am going to revert this CL.
>> >
>> > https://chromiumcodereview.appspot.com/10073005/
>>
>
>