Issue 10086021: Revert 132268 - Single URL Expires Were Not Being Deleted.

Issue 10086021: Revert 132268 - Single URL Expires Were Not Being Deleted. (Closed)

Created:
8 years, 8 months ago by mrossetti

Modified:
8 years, 8 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, mihaip+watch_chromium.org, Aaron Boodman, brettw-cc_chromium.org, James Su, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 132268 - Single URL Expires Were Not Being Deleted. Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows. tim@ for OWNERS review of sync/... BUG=122740 TEST=Added unit test. TBR=tim@chromium.org Review URL: https://chromiumcodereview.appspot.com/10031028 TBR=mrossetti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132297

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -120 lines)			Patch
M	chrome/browser/autocomplete/network_action_predictor.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/network_action_predictor.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/network_action_predictor_unittest.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/android/android_provider_backend.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	chrome/browser/history/android/android_provider_backend_unittest.cc	View	5 chunks	+15 lines, -0 lines	0 comments	Download
MM	chrome/browser/history/expire_history_backend.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
MM	chrome/browser/history/expire_history_backend_unittest.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
MM	chrome/browser/history/history.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/history/history_extension_api.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
MM	chrome/browser/history/history_notifications.h	View	1 chunk	+8 lines, -2 lines	0 comments	Download
MM	chrome/browser/history/history_types.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
MM	chrome/browser/history/in_memory_url_index_unittest.cc	View	5 chunks	+1 line, -32 lines	0 comments	Download
MM	chrome/browser/history/shortcuts_backend.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
MM	chrome/browser/history/top_sites.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
MM	chrome/browser/sync/glue/typed_url_change_processor.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
MM	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View	2 chunks	+4 lines, -16 lines	0 comments	Download
MM	chrome/browser/visitedlink/visitedlink_master.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
MM	chrome/browser/visitedlink/visitedlink_master.cc	View	3 chunks	+8 lines, -12 lines	0 comments	Download
MM	chrome/browser/visitedlink/visitedlink_unittest.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages