Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 10086021: Revert 132268 - Single URL Expires Were Not Being Deleted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/expire_history_backend_unittest.cc
===================================================================
--- chrome/browser/history/expire_history_backend_unittest.cc (revision 132295)
+++ chrome/browser/history/expire_history_backend_unittest.cc (working copy)
@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <algorithm>
#include <string>
#include <utility>
@@ -382,10 +381,10 @@
bool found_delete_notification = false;
for (size_t i = 0; i < notifications_.size(); i++) {
if (notifications_[i].first == chrome::NOTIFICATION_HISTORY_URLS_DELETED) {
- const history::URLRows& rows(reinterpret_cast<URLsDeletedDetails*>(
- notifications_[i].second)->rows);
- if (std::find_if(rows.begin(), rows.end(),
- history::URLRow::URLRowHasURL(row.url())) != rows.end()) {
+ const URLsDeletedDetails* deleted_details =
+ reinterpret_cast<URLsDeletedDetails*>(notifications_[i].second);
+ if (deleted_details->urls.find(row.url()) !=
+ deleted_details->urls.end()) {
found_delete_notification = true;
}
} else {
Property changes on: chrome/browser/history/expire_history_backend_unittest.cc
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698