Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 10084009: Remove duplicated |profile_| attribute in |CannedBrowsingDataCookieHelper|. (Closed)

Created:
8 years, 8 months ago by markusheintz_
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove duplicated |profile_| attribute in |CannedBrowsingDataCookieHelper|. BUG=none TEST=BrowsingDataCookieHelperTest.Canned* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132380

Patch Set 1 #

Patch Set 2 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/browsing_data_cookie_helper.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/browsing_data_cookie_helper.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
markusheintz_
Please review this CL. Thanks
8 years, 8 months ago (2012-04-13 14:13:18 UTC) #1
jochen (gone - plz use gerrit)
lgtm
8 years, 8 months ago (2012-04-13 14:15:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10084009/1001
8 years, 8 months ago (2012-04-13 14:24:37 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 14:27:44 UTC) #4
Try job failure for 10084009-1001 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698