Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: chrome/browser/browsing_data_cookie_helper.h

Issue 10084009: Remove duplicated |profile_| attribute in |CannedBrowsingDataCookieHelper|. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/browsing_data_cookie_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_
6 #define CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 25 matching lines...) Expand all
36 virtual void StartFetching( 36 virtual void StartFetching(
37 const base::Callback<void(const net::CookieList& cookies)>& callback); 37 const base::Callback<void(const net::CookieList& cookies)>& callback);
38 38
39 // Requests a single cookie to be deleted in the IO thread. This must be 39 // Requests a single cookie to be deleted in the IO thread. This must be
40 // called in the UI thread. 40 // called in the UI thread.
41 virtual void DeleteCookie(const net::CookieMonster::CanonicalCookie& cookie); 41 virtual void DeleteCookie(const net::CookieMonster::CanonicalCookie& cookie);
42 42
43 protected: 43 protected:
44 friend class base::RefCountedThreadSafe<BrowsingDataCookieHelper>; 44 friend class base::RefCountedThreadSafe<BrowsingDataCookieHelper>;
45 virtual ~BrowsingDataCookieHelper(); 45 virtual ~BrowsingDataCookieHelper();
46 Profile* profile() { return profile_; }
46 47
47 private: 48 private:
48 // Fetch the cookies. This must be called in the IO thread. 49 // Fetch the cookies. This must be called in the IO thread.
49 void FetchCookiesOnIOThread(); 50 void FetchCookiesOnIOThread();
50 51
51 // Callback function for get cookie. This must be called in the IO thread. 52 // Callback function for get cookie. This must be called in the IO thread.
52 void OnFetchComplete(const net::CookieList& cookies); 53 void OnFetchComplete(const net::CookieList& cookies);
53 54
54 // Notifies the completion callback. This must be called in the UI thread. 55 // Notifies the completion callback. This must be called in the UI thread.
55 void NotifyInUIThread(const net::CookieList& cookies); 56 void NotifyInUIThread(const net::CookieList& cookies);
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 // Check if the cookie list contains a cookie with the same name, 112 // Check if the cookie list contains a cookie with the same name,
112 // domain, and path as the newly created cookie. Delete the old cookie 113 // domain, and path as the newly created cookie. Delete the old cookie
113 // if does. 114 // if does.
114 bool DeleteMetchingCookie( 115 bool DeleteMetchingCookie(
115 const net::CookieMonster::CanonicalCookie& add_cookie); 116 const net::CookieMonster::CanonicalCookie& add_cookie);
116 117
117 virtual ~CannedBrowsingDataCookieHelper(); 118 virtual ~CannedBrowsingDataCookieHelper();
118 119
119 net::CookieList cookie_list_; 120 net::CookieList cookie_list_;
120 121
121 Profile* profile_;
122
123 DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataCookieHelper); 122 DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataCookieHelper);
124 }; 123 };
125 124
126 #endif // CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_ 125 #endif // CHROME_BROWSER_BROWSING_DATA_COOKIE_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browsing_data_cookie_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698