Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10083057: Revert 132856 - Aura/ash split: Remove hacks and get chrome linking without ash. (Closed)

Created:
8 years, 8 months ago by Elliot Glaysher
Modified:
8 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Revert 132856 - Aura/ash split: Remove hacks and get chrome linking without ash. views_unittests failure on Linux Chromeos. For the first time now, you can do: > build/gyp_chromium -Duse_aura=1 -Duse_ash=0 And get a running chrome. It has lots of issues, especially related to window placement, tab handling, etc, but it pops up and renders web content. Also consolidates most of the desktop behavior into its own class. Also makes views_examples_exe work again. Several of the hacks are no longer needed after Ben's refactoring to support WebView. BUG=116458, 119759 TEST=none Review URL: http://codereview.chromium.org/10081022 TBR=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -498 lines) Patch
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/fullscreen_ash.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/fullscreen_aura.cc View 1 chunk +25 lines, -7 lines 0 comments Download
D chrome/browser/ui/tabs/dock_info_ash.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/ui/tabs/dock_info_aura.cc View 3 chunks +37 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A + chrome/browser/ui/views/ash/color_chooser_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/views/color_chooser_aura.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +1 line, -4 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/aura/desktop/desktop_stacking_client.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/aura/desktop/desktop_stacking_client.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.h View 2 chunks +1 line, -7 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 3 chunks +33 lines, -3 lines 0 comments Download
MM ui/views/test/test_views_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 2 chunks +0 lines, -11 lines 0 comments Download
MM ui/views/views.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
MM ui/views/views_delegate.h View 2 chunks +0 lines, -12 lines 0 comments Download
D ui/views/widget/desktop_native_widget_helper_aura.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/views/widget/desktop_native_widget_helper_aura.cc View 1 chunk +0 lines, -78 lines 0 comments Download
MM ui/views/widget/native_widget_aura.h View 6 chunks +13 lines, -3 lines 0 comments Download
MM ui/views/widget/native_widget_aura.cc View 10 chunks +52 lines, -16 lines 0 comments Download
D ui/views/widget/native_widget_helper_aura.h View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Elliot Glaysher
8 years, 8 months ago (2012-04-18 21:00:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698