Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 10082029: Ash: Fix hit testing for the bottom pixels of tabs (Closed)

Created:
8 years, 8 months ago by James Cook
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Ash: Fix hit testing for the bottom pixels of tabs * Ash uses a taller content area shadow, so the toolbar needs to avoid taking mouse clicks along its top 2 pixels, as they overlap the tab strip. * Added more GetClassName() implementations for views to help with future debugging. * Removed an attempt to forward-declare an enum. BUG=123354 TEST=manual, ensure that hovering mouse along the very bottom of a tab results in the hover-glow effect Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Scott, PTAL.
8 years, 8 months ago (2012-04-13 23:05:23 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-13 23:30:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/10082029/1
8 years, 8 months ago (2012-04-14 00:20:13 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 03:28:08 UTC) #4
Try job failure for 10082029-1 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698