Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2010)

Unified Diff: ui/views/widget/root_view.cc

Issue 10082029: Ash: Fix hit testing for the bottom pixels of tabs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/root_view.cc
diff --git a/ui/views/widget/root_view.cc b/ui/views/widget/root_view.cc
index ebad36377bc3fc14ad12999c5311d77aec9c8ac5..bc20e0f7c375eab657a763c7485d2699b3dacbf7 100644
--- a/ui/views/widget/root_view.cc
+++ b/ui/views/widget/root_view.cc
@@ -217,6 +217,8 @@ bool RootView::OnMousePressed(const MouseEvent& event) {
for (mouse_pressed_handler_ = GetEventHandlerForPoint(e.location());
mouse_pressed_handler_ && (mouse_pressed_handler_ != this);
mouse_pressed_handler_ = mouse_pressed_handler_->parent()) {
+ DVLOG(1) << "OnMousePressed testing "
+ << mouse_pressed_handler_->GetClassName();
if (!mouse_pressed_handler_->enabled()) {
// Disabled views should eat events instead of propagating them upwards.
hit_disabled_view = true;
@@ -250,6 +252,8 @@ bool RootView::OnMousePressed(const MouseEvent& event) {
// forwarded to that view.
if (handled) {
last_click_handler_ = mouse_pressed_handler_;
+ DVLOG(1) << "OnMousePressed handled by "
+ << mouse_pressed_handler_->GetClassName();
return true;
}
}
@@ -261,7 +265,7 @@ bool RootView::OnMousePressed(const MouseEvent& event) {
// entire hierarchy (even as a single-click when sent to a different view),
// it must be marked as handled to avoid anything happening from default
// processing if it the first click-part was handled by us.
- if (last_click_handler_ && e.flags() & ui::EF_IS_DOUBLE_CLICK)
+ if (last_click_handler_ && (e.flags() & ui::EF_IS_DOUBLE_CLICK))
hit_disabled_view = true;
last_click_handler_ = NULL;
« no previous file with comments | « ui/views/view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698