Issue 10081032: Proper fix for MockGDataSyncClient cleanup

Issue 10081032: Proper fix for MockGDataSyncClient cleanup (Closed)

Created:
8 years, 8 months ago by zel

Modified:
8 years, 8 months ago

Reviewers:
achuithb, satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Proper fix for https://chromiumcodereview.appspot.com/10073005 : gdata: Remove OnDirectoryChanged from MockGDataSyncClient, added MockDirectoryChangeObserver for directory change notifications. BUG=none TEST=existing GDataFileSystemTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132322

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : clang fixes #

Patch Set 5 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -27 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1	18 chunks	+30 lines, -26 lines	0 comments	Download
A	chrome/browser/chromeos/gdata/mock_directory_change_observer.h	View	1 3 4	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/gdata/mock_directory_change_observer.cc	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_sync_client.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10081032/6004

8 years, 8 months ago (2012-04-14 01:21:29 UTC) #3

satorux1

Thanks! On Apr 13, 2012 4:40 PM, <commit-bot@chromium.org> wrote: > Change committed as 132312 > ...

8 years, 8 months ago (2012-04-14 03:09:08 UTC) #5

achuithb

This just got reverted due to a clang compile failure.. On 2012/04/14 03:09:08, satorux1 wrote: ...

8 years, 8 months ago (2012-04-14 03:11:38 UTC) #6

zel

I know, working on a fix at http://codereview.chromium.org/10081032/ On Fri, Apr 13, 2012 at 8:11 ...

8 years, 8 months ago (2012-04-14 03:13:41 UTC) #7

achuithb

8 years, 8 months ago (2012-04-14 03:18:20 UTC) #8

Let me know if you need me to land this for you over the weekend.. 

On 2012/04/14 03:13:41, zel wrote:
> I know, working on a fix at http://codereview.chromium.org/10081032/
> 
> 
> On Fri, Apr 13, 2012 at 8:11 PM, <mailto:achuith@chromium.org> wrote:
> 
> > This just got reverted due to a clang compile failure..
> >
> >
> > On 2012/04/14 03:09:08, satorux1 wrote:
> >
> >  Thanks!
> >>
> >> On Apr 13, 2012 4:40 PM,
> <mailto:commit-bot@chromium.**org<commit-bot@chromium.org>>
> >> wrote:
> >>
> >
> >  > Change committed as 132312
> >>
> >
> >  >
> >>
> >
> > http://codereview.chromium.****org/10081032/%253Chttp://coderev**
> > iew.chromium.org/10081032/ <http://codereview.chromium.org/10081032/>>
> >
> >
> >
> >
> >
>
http://codereview.chromium.**org/10081032/%3Chttp://codereview.chromium.org/1...>
> >

Expand Messages | Collapse Messages