Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10080017: Switch platform apps from a declarative launch container to handling an onLaunched event. (Closed)

Created:
8 years, 8 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Switch platform apps from a declarative launch container to handling an onLaunched event. Platform apps must now have a background page. For the handling of launches, the background page registers an onLaunched event handler, and creates UI as appropriate via the chrome.windows.* API. Updates all tests to use the new window model. Also makes created shell window respect the bounds that were passed into the chrome.windows.create() call. Also fixes bug by resizing windows in PlatformAppBrowserTest.WindowsApi to a size that matches the Aura grid. This CL was originally written by mihaip@chromium.org - the original is: http://codereview.chromium.org/9969087/ TBR=mihaip@chromium.org BUG=119410 TEST=Platform apps should now require a background page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133555

Patch Set 1 #

Patch Set 2 : rebased against trunk #

Patch Set 3 : remove debug logging code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -607 lines) Patch
M chrome/browser/extensions/api/app/app_api.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/app/app_api.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 9 chunks +26 lines, -44 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 1 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.cc View 1 1 chunk +2 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 4 chunks +3 lines, -29 lines 0 comments Download
M chrome/common/extensions/api/experimental.app.json View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 chunks +2 lines, -23 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 7 chunks +21 lines, -81 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 4 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 1 1 chunk +1 line, -32 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/dns/api/main.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/dns/api/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/identity/launch.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/identity/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/serial/api/main.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/serial/api/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/socket/api/main.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/socket/api/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/generic_platform_app.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/extensions/generic_platform_app.pem View 1 chunk +0 lines, -15 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_1.json View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_2.json View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_valid_platform_app.json View 1 chunk +2 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_container_invalid_size_constraints.json View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_container_invalid_type_for_platform.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_container_missing_size_for_platform.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_min_height_invalid.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_min_height_negative.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_min_width_invalid.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_min_width_negative.json View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/context_menu/main.html View 1 chunk +10 lines, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/context_menu/main.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/context_menu/manifest.json View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/context_menu/test.js View 1 chunk +13 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/empty/empty.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/empty/manifest.json View 1 chunk +0 lines, -14 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/empty_context_menu/main.html View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/empty_context_menu/main.js View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/empty_context_menu/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/empty_context_menu/test.js View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/launch/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/launch/test.js View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/navigation/main.js View 3 chunks +18 lines, -15 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/navigation/manifest.json View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/navigation/nav-target.js View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/navigation/test.js View 1 chunk +10 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/restrictions/main.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/manifest.json View 1 chunk +2 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/storage/main.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/storage/main.js View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/storage/manifest.json View 1 chunk +2 lines, -7 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/storage/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/windows_api/main.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/windows_api/main.js View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/windows_api/manifest.json View 1 chunk +6 lines, -8 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/windows_api/test.js View 2 1 chunk +55 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698