Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5916)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

Issue 10080017: Switch platform apps from a declarative launch container to handling an onLaunched event. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: remove debug logging code Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc
index 57fa5558025d7472078ccd26559eb3ae45da4c45..84cdf8d584778a670f739c9c0defb7d467bc31cf 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc
@@ -54,43 +54,12 @@ TEST_F(ExtensionManifestTest, AppLaunchContainer) {
Testcase("launch_height_negative.json",
ExtensionErrorUtils::FormatErrorMessage(
errors::kInvalidLaunchValue,
- keys::kLaunchHeight)),
- Testcase("launch_min_width_invalid.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValueContainer,
- keys::kLaunchMinWidth)),
- Testcase("launch_min_width_negative.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValue,
- keys::kLaunchMinWidth)),
- Testcase("launch_min_height_invalid.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValueContainer,
- keys::kLaunchMinHeight)),
- Testcase("launch_min_height_negative.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValue,
- keys::kLaunchMinHeight)),
- Testcase("launch_container_missing_size_for_platform.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValue,
- keys::kLaunchWidth)),
- Testcase("launch_container_invalid_size_constraints.json",
- ExtensionErrorUtils::FormatErrorMessage(
- errors::kInvalidLaunchValue,
- keys::kLaunchMaxWidth))
+ keys::kLaunchHeight))
};
RunTestcases(testcases, arraysize(testcases),
EXPECT_TYPE_ERROR);
}
-TEST_F(ExtensionManifestTest, PlatformAppLaunchContainer) {
- CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePlatformApps);
-
- LoadAndExpectError("launch_container_invalid_type_for_platform.json",
- errors::kInvalidLaunchContainerForPlatform);
-}
-
TEST_F(ExtensionManifestTest, AppLaunchURL) {
Testcase testcases[] = {
Testcase("launch_path_and_url.json",

Powered by Google App Engine
This is Rietveld 408576698