Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10078006: Revert 132934 - this change seems to break many webgl related layout tests (Closed)

Created:
8 years, 8 months ago by Takashi Toyoshima
Modified:
8 years, 8 months ago
Reviewers:
Jeff Timanus
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Revert 132934 - this change seems to break many webgl related layout tests Introduction of CHROMIUM_copy_texture extension that respects pixel-store semantics, and allows copying of BGRA textures. OpenGL ES does not natively allow for copying textures with a BGRA format. The EXT_texture_format_BGRA8888 extension does not specify support for glCopyTexImage calls on these textures. This extension provides a routine to perform texture copies to/from BGRA-backed textures that also respects the following CHROMIUM pixel storage modifiers: UNPACK_FLIP_Y_CHROMIUM UNPACK_PREMULTIPLY_ALPHA_CHROMIUM This extension will be useful for the following purposes: - Copying accelerated Canvas2D contents to WebGL textures without a software readback. (And potentially the same for video-webgl texture copies.) - Copying Canvas2D contents to the compositor backing store. BUG=101051 TEST=none Review URL: http://codereview.chromium.org/9968113 TBR=twiz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -987 lines) Patch
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 1 chunk +0 lines, -66 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 11 chunks +5 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +0 lines, -48 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +0 lines, -19 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
D gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 1 chunk +0 lines, -41 lines 0 comments Download
D gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 22 chunks +8 lines, -168 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 2 chunks +1 line, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 15 chunks +15 lines, -56 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 5 chunks +4 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 12 chunks +5 lines, -206 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Takashi Toyoshima
8 years, 8 months ago (2012-04-19 05:53:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698