Check implementation files for virtual and OVERRIDE

Check implementation files for virtual and OVERRIDE.

Currently behind a flag "-Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations"

BUG=115047
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132507

[Ryan Sleevi, 2012-04-14 02:06:06]

Nico: And here's the second part.

I'm going to poke around this weekend to see about adding note annotations that
indicate the original symbol and decl as a context hint. Mostly because I expect
a ton of implementation files not to be following the style-guides "group
implementations into sections and annotate with "// Foo implementation", so
having the context at hand will be easier.

[Ryan Sleevi, 2012-04-17 00:36:52]

Nico: Ping for existing CL

[Nico, 2012-04-17 00:46:00]

Sorry, feel free to ping sooner. Just a few nits.

http://codereview.chromium.org/10076002/diff/1/tools/clang/plugins/FindBadCon...
File tools/clang/plugins/FindBadConstructs.cpp (right):

http://codereview.chromium.org/10076002/diff/1/tools/clang/plugins/FindBadCon...
tools/clang/plugins/FindBadConstructs.cpp:73:
CheckVirtualMethods(record_location, record, !implementation_file);
Do:

bool warn_on_inline_bodies = !implementation_file;

pass that as parameter, and revert the change to the comment.

http://codereview.chromium.org/10076002/diff/1/tools/clang/plugins/FindBadCon...
tools/clang/plugins/FindBadConstructs.cpp:78: // or base::RefCountedThreadSafe
does not have a public destructor.
useless comment, remove (the method comment already says this; if you feel it's
worth repeating give the method a better name instead)

http://codereview.chromium.org/10076002/diff/1/tools/clang/plugins/tests/over...
File tools/clang/plugins/tests/overridden_methods.cpp (right):

http://codereview.chromium.org/10076002/diff/1/tools/clang/plugins/tests/over...
tools/clang/plugins/tests/overridden_methods.cpp:27: // Should warn for inline
implementations.
in cpp files?

http://codereview.chromium.org/10076002/diff/1/tools/clang/scripts/plugin_fla...
File tools/clang/scripts/plugin_flags.sh (right):

http://codereview.chromium.org/10076002/diff/1/tools/clang/scripts/plugin_fla...
tools/clang/scripts/plugin_flags.sh:23: -Xclang skip-virtuals-in-implementations
indent like the previous lines

[Ryan Sleevi, 2012-04-17 01:28:35]

Nits addressed. LGTY?

[Nico, 2012-04-17 01:29:43]

lgtm