Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: tools/clang/plugins/tests/virtual_methods.cpp

Issue 10076002: Check implementation files for virtual and OVERRIDE (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copyright bump Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.txt ('k') | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "virtual_methods.h" 5 #include "virtual_methods.h"
6 6
7 // Shouldn't warn about method usage in the implementation file. 7 // Shouldn't warn about method usage in the implementation file.
8 class VirtualMethodsInImplementation { 8 class VirtualMethodsInImplementation {
9 public: 9 public:
10 virtual void MethodIsAbstract() = 0; 10 virtual void MethodIsAbstract() = 0;
11 virtual void MethodHasNoArguments(); 11 virtual void MethodHasNoArguments();
12 virtual void MethodHasEmptyDefaultImpl() {} 12 virtual void MethodHasEmptyDefaultImpl() {}
13 virtual bool ComplainAboutThis() { return true; } 13 virtual bool ComplainAboutThis() { return true; }
14 }; 14 };
15 15
16 // Stubs to fill in the abstract method 16 // Stubs to fill in the abstract method
17 class ConcreteVirtualMethodsInHeaders : public VirtualMethodsInHeaders { 17 class ConcreteVirtualMethodsInHeaders : public VirtualMethodsInHeaders {
18 public: 18 public:
19 virtual void MethodIsAbstract() {} 19 virtual void MethodIsAbstract() override {}
20 }; 20 };
21 21
22 class ConcreteVirtualMethodsInImplementation 22 class ConcreteVirtualMethodsInImplementation
23 : public VirtualMethodsInImplementation { 23 : public VirtualMethodsInImplementation {
24 public: 24 public:
25 virtual void MethodIsAbstract() {} 25 virtual void MethodIsAbstract() override {}
26 }; 26 };
27 27
28 // Fill in the implementations 28 // Fill in the implementations
29 void VirtualMethodsInHeaders::MethodHasNoArguments() {} 29 void VirtualMethodsInHeaders::MethodHasNoArguments() {}
30 void WarnOnMissingVirtual::MethodHasNoArguments() {} 30 void WarnOnMissingVirtual::MethodHasNoArguments() {}
31 void VirtualMethodsInImplementation::MethodHasNoArguments() {} 31 void VirtualMethodsInImplementation::MethodHasNoArguments() {}
32 32
33 int main() { 33 int main() {
34 ConcreteVirtualMethodsInHeaders one; 34 ConcreteVirtualMethodsInHeaders one;
35 ConcreteVirtualMethodsInImplementation two; 35 ConcreteVirtualMethodsInImplementation two;
36 } 36 }
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.txt ('k') | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698