Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.h

Issue 10073018: Add Delete Support to New Autofill UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate.h
diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h
index 18aa57c4060565d5543969d63310f94aa93e22bc..4cdd7ea81f7f39f1f5004f42fea5dde902936a05 100644
--- a/chrome/browser/autofill/autofill_external_delegate.h
+++ b/chrome/browser/autofill/autofill_external_delegate.h
@@ -35,7 +35,7 @@ class AutofillExternalDelegate {
// When using an external Autofill delegate. Allows Chrome to tell
// WebKit which Autofill selection has been chosen.
// TODO(jrg): add feedback mechanism for hover on relevant platforms.
Ilya Sherman 2012/04/20 21:30:48 nit: Is this TODO still relevant, or has this been
csharp 2012/04/24 14:18:48 This has been addressed for Linux, so I'll remove
- virtual void SelectAutofillSuggestionAtIndex(int unique_id, int list_index);
+ virtual void SelectAutofillSuggestionAtIndex(int unique_id);
// Records and associates a query_id with web form data. Called
// when the renderer posts an Autofill query to the browser. |bounds|
@@ -64,6 +64,12 @@ class AutofillExternalDelegate {
const webkit::forms::FormField& field,
const gfx::Rect& bounds);
+ // Remove the given Autocomplete entry from the DB.
+ void RemoveAutocompleteEntry(const string16& value);
+
+ // Remove the given Autofill profile or credit credit.
+ void RemoveAutofillProfileOrCreditCard(int unique_id);
+
// Inform the delegate that the text field editing has ended, this is
// used to help record the metrics of when a new popup is shown.
void DidEndTextFieldEditing();
@@ -149,12 +155,6 @@ class AutofillExternalDelegate {
// currently editing? Used to keep track of state for metrics logging.
bool has_shown_autofill_popup_for_current_edit_;
- // The menu index of the "Clear" menu item.
- int suggestions_clear_index_;
-
- // The menu index of the "Autofill options..." menu item.
- int suggestions_options_index_;
-
DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698