Add Delete Support to New Autofill UI

chrome/browser/autofill/autofill_external_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 16 matching lines @@
 // this logic. See http://crbug.com/51644
 
 // Delegate for external processing of Autocomplete and Autofill
 // display and selection.
 class AutofillExternalDelegate {
  public:
   virtual ~AutofillExternalDelegate();
 
   // When using an external Autofill delegate.  Allows Chrome to tell
   // WebKit which Autofill selection has been chosen.
   // TODO(jrg): add feedback mechanism for hover on relevant platforms.

[Ilya Sherman, 2012/04/20 21:30:48]

nit: Is this TODO still relevant, or has this been addressed?

[csharp, 2012/04/24 14:18:48]

This has been addressed for Linux, so I'll remove the todo (other platforms have
a lot of things they'll need to implement and they aren't marked with todos).

-  virtual void SelectAutofillSuggestionAtIndex(int unique_id, int list_index);
+  virtual void SelectAutofillSuggestionAtIndex(int unique_id);
 
   // Records and associates a query_id with web form data.  Called
   // when the renderer posts an Autofill query to the browser. |bounds|
   // is window relative. |display_warning_if_disabled| tells us if we should
   // display warnings (such as autofill is disabled, but had suggestions).
   // We might not want to display the warning if a website has disabled
   // Autocomplete because they have their own popup, and showing our popup
   // on to of theirs would be a poor user experience.
   virtual void OnQuery(int query_id,
                        const webkit::forms::FormData& form,
                        const webkit::forms::FormField& field,
                        const gfx::Rect& bounds,
                        bool display_warning_if_disabled);
 
   // Records query results and correctly formats them before sending them off
   // to be displayed.  Called when an Autofill query result is available.
   virtual void OnSuggestionsReturned(
       int query_id,
       const std::vector<string16>& autofill_values,
       const std::vector<string16>& autofill_labels,
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids);
 
   // Show password suggestions in the popup.
   void OnShowPasswordSuggestions(const std::vector<string16>& suggestions,
                                  const webkit::forms::FormField& field,
                                  const gfx::Rect& bounds);
 
+  // Remove the given Autocomplete entry from the DB.
+  void RemoveAutocompleteEntry(const string16& value);
+
+  // Remove the given Autofill profile or credit credit.
+  void RemoveAutofillProfileOrCreditCard(int unique_id);
+
   // Inform the delegate that the text field editing has ended, this is
   // used to help record the metrics of when a new popup is shown.
   void DidEndTextFieldEditing();
 
   // Inform the delegate that an autofill suggestion have been chosen. Returns
   // true if the suggestion was selected.
   bool DidAcceptAutofillSuggestions(const string16& value,
                                     int unique_id,
                                     unsigned index);
 
@@ skipping 65 matching lines @@
   webkit::forms::FormData autofill_query_form_;
   webkit::forms::FormField autofill_query_field_;
 
   // Should we display a warning if Autofill is disabled?
   bool display_warning_if_disabled_;
 
   // Have we already shown Autofill suggestions for the field the user is
   // currently editing?  Used to keep track of state for metrics logging.
   bool has_shown_autofill_popup_for_current_edit_;
 
-  // The menu index of the "Clear" menu item.
-  int suggestions_clear_index_;
-
-  // The menu index of the "Autofill options..." menu item.
-  int suggestions_options_index_;
-
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_