Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4370)

Unified Diff: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

Issue 10073018: Add Delete Support to New Autofill UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
index ed1f84a20708654b80bdc23e00aa4d833440537e..795dd8e12c56ebdc659851b743379fedac2f1ed3 100644
--- a/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
+++ b/chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc
@@ -238,7 +238,7 @@ bool AutofillPopupViewGtk::HandleKeyPressEvent(GdkEventKey* event) {
return true;
case GDK_Delete:
case GDK_KP_Delete:
- return (event->state == GDK_SHIFT_MASK) && RemoveSelectedLine();
+ return (event->state & GDK_SHIFT_MASK) && RemoveSelectedLine();
Ilya Sherman 2012/04/17 08:31:20 Does this mean that ctrl-shift-delete and other su
csharp 2012/04/18 15:35:58 Fixed. There seem to be other modifiers on by defa
Ilya Sherman 2012/04/18 18:12:51 Ah, that's tricky. Nice job finding how to do tha
case GDK_Return:
case GDK_KP_Enter:
return AcceptSelectedLine();

Powered by Google App Engine
This is Rietveld 408576698