Add Delete Support to New Autofill UI

chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "autofill_popup_view_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
@@ skipping 220 matching lines @@
       SetSelectedLine(0);
       return true;
     case GDK_Page_Down:
       SetSelectedLine(autofill_values().size() - 1);
       return true;
     case GDK_Escape:
       Hide();
       return true;
     case GDK_Delete:
     case GDK_KP_Delete:
-      return (event->state == GDK_SHIFT_MASK) && RemoveSelectedLine();
+      return (event->state & GDK_SHIFT_MASK) && RemoveSelectedLine();

[Ilya Sherman, 2012/04/17 08:31:20]

Does this mean that ctrl-shift-delete and other such shortcuts will also delete
the item?  I'd prefer that shift-delete and nothing else be the keyboard
shortcut for deleting.

[csharp, 2012/04/18 15:35:58]

Fixed. There seem to be other modifiers on by default, I grabbed a fix the other
gtk seems to use.

[Ilya Sherman, 2012/04/18 18:12:51]

Ah, that's tricky.  Nice job finding how to do that :)

     case GDK_Return:
     case GDK_KP_Enter:
       return AcceptSelectedLine();
   }
 
   return false;
 }
 
 void AutofillPopupViewGtk::SetupLayout(const gfx::Rect& window_rect,
                                        const GdkColor& text_color) {
@@ skipping 24 matching lines @@
                            kMiddlePadding +
                            font_.GetStringWidth(autofill_labels()[i]));
   }
 
   return popup_width;
 }
 
 int AutofillPopupViewGtk::LineFromY(int y) {
   return y / row_height_;
 }