Issue 10070014: revert 4 untested commits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10070014: revert 4 untested commits (Closed)

Created:
8 years, 8 months ago by pasko-google - do not use

Modified:
8 years, 8 months ago

Reviewers:
khim

CC:
native-client-reviews_googlegroups.com, Mark Seaborn, Roland McGrath

Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master

Visibility:
Public.

More Reviews

Description

revert 4 untested commits Revert these: e98ec8c fixed signatures for several syscalls that return positive value in correct case 256e1ec removed epoll_create1 (EPOLL_CLOEXEC is not applicable to NaCl, as there is no possibility to fork); added recv and send to syscalls.list 0533bbb added several system call hooks for future sockets implementation BUG=broken REVISIONS roll TEST=cd native_client/tools && make glibc-check Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=9b90506

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -401 lines)			Patch
M	elf/Versions	View	3 chunks	+1 line, -31 lines	0 comments	Download
M	make_sysd_rules.py	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	sysdeps/nacl/irt_syscalls.h	View	5 chunks	+1 line, -66 lines	0 comments	Download
M	sysdeps/nacl/irt_syscalls.c	View	3 chunks	+0 lines, -91 lines	0 comments	Download
M	sysdeps/nacl/syscalls.list	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	sysdeps/nacl/sysdep.h	View	10 chunks	+29 lines, -171 lines	0 comments	Download
M	sysdeps/unix/make-syscalls.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sysdeps/unix/sysv/linux/sys/syscall.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

I sent this on trybot, it's been very slow. So I manually ran: make clean ...

8 years, 8 months ago (2012-04-19 19:43:01 UTC) #1

khim

8 years, 8 months ago (2012-04-19 19:45:17 UTC) #2

LGTM

Ideally you'd like to also pass regular NaCl tests (trybot does this).

Expand Messages | Collapse Messages