Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10067022: Mask VM crash for realsies. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 6487)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -275,13 +275,13 @@
bool get hasFailed() {
// TODO(efortuna): This is a total hack to keep our buildbots (more) green
// while the VM team solves Issue 2124. Remove when issue is fixed.
- if (new Platform().operatingSystem() == 'windows' && exitCode == 253) {
+ if (new Platform().operatingSystem() == 'windows' && (exitCode == 253 ||
+ exitCode == 3)) {
for (String line in testCase.output.stdout) {
if (line.startsWith('VM exited with signal 1073741819') ||
- line.startsWith('Kind: ')) {
+ line.startsWith('Kind:')) {
if (!alreadyPrintedWarning) {
- print("WARNING: VM crashed on this test with signal 1073741819. " +
- "This is a fake pass!!");
+ print("WARNING: VM crashed: $line This is a fake pass!!");
alreadyPrintedWarning = true;
}
return testCase.expectedOutcomes.iterator().next() == FAIL;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698