Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 10067022: Mask VM crash for realsies. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 bool get hasTimedOut() => timedOut; 268 bool get hasTimedOut() => timedOut;
269 269
270 bool get didFail() { 270 bool get didFail() {
271 return (exitCode != 0 && !hasCrashed); 271 return (exitCode != 0 && !hasCrashed);
272 } 272 }
273 273
274 // Reverse result of a negative test. 274 // Reverse result of a negative test.
275 bool get hasFailed() { 275 bool get hasFailed() {
276 // TODO(efortuna): This is a total hack to keep our buildbots (more) green 276 // TODO(efortuna): This is a total hack to keep our buildbots (more) green
277 // while the VM team solves Issue 2124. Remove when issue is fixed. 277 // while the VM team solves Issue 2124. Remove when issue is fixed.
278 if (new Platform().operatingSystem() == 'windows' && exitCode == 253) { 278 if (new Platform().operatingSystem() == 'windows' && (exitCode == 253 ||
279 exitCode == 3)) {
279 for (String line in testCase.output.stdout) { 280 for (String line in testCase.output.stdout) {
280 if (line.startsWith('VM exited with signal 1073741819') || 281 if (line.startsWith('VM exited with signal 1073741819') ||
281 line.startsWith('Kind: ')) { 282 line.startsWith('Kind:')) {
282 if (!alreadyPrintedWarning) { 283 if (!alreadyPrintedWarning) {
283 print("WARNING: VM crashed on this test with signal 1073741819. " + 284 print("WARNING: VM crashed: $line This is a fake pass!!");
284 "This is a fake pass!!");
285 alreadyPrintedWarning = true; 285 alreadyPrintedWarning = true;
286 } 286 }
287 return testCase.expectedOutcomes.iterator().next() == FAIL; 287 return testCase.expectedOutcomes.iterator().next() == FAIL;
288 } 288 }
289 } 289 }
290 } 290 }
291 return (testCase.isNegative ? !didFail : didFail); 291 return (testCase.isNegative ? !didFail : didFail);
292 } 292 }
293 293
294 } 294 }
(...skipping 848 matching lines...) Expand 10 before | Expand all | Expand 10 after
1143 // the developer doesn't waste his or her time trying to fix a bunch of 1143 // the developer doesn't waste his or her time trying to fix a bunch of
1144 // tests that appear to be broken but were actually just flakes that 1144 // tests that appear to be broken but were actually just flakes that
1145 // didn't get retried because there had already been one failure. 1145 // didn't get retried because there had already been one failure.
1146 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1146 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1147 new RunningProcess(test, allowRetry, this).start(); 1147 new RunningProcess(test, allowRetry, this).start();
1148 } 1148 }
1149 _numProcesses++; 1149 _numProcesses++;
1150 } 1150 }
1151 } 1151 }
1152 } 1152 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698