Issue 10066043: Revert 132134 - Use LocalFileReader in FileSystemURLRequestJob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10066043: Revert 132134 - Use LocalFileReader in FileSystemURLRequestJob (Closed)

Created:
8 years, 8 months ago by Alexander Potapenko

Modified:
8 years, 8 months ago

Reviewers:
kinuko

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 132134 - Use LocalFileReader in FileSystemURLRequestJob Reason: multiple leak reports on the Memory FYI waterfall (Valgrind, Heapcheck). - to avoid file access on IO thread - to remove duplicated code - for further FileSystem stream related refactoring BUG=113300, 114999, 123302 TEST=FileSystemURLRequestJobTest.* Review URL: https://chromiumcodereview.appspot.com/10065011 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132162

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -22 lines)			Patch
M	webkit/blob/blob_url_request_job.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
MM	webkit/blob/local_file_reader.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
MM	webkit/blob/local_file_reader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	webkit/fileapi/file_system_url_request_job.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
MM	webkit/fileapi/file_system_url_request_job.cc	View	9 chunks	+64 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

kinuko

8 years, 8 months ago (2012-04-13 09:30:33 UTC) #2

On 2012/04/13 09:16:22, Alexander Potapenko wrote:

Oops was about to submit a fix... well will reland together with it. Thanks
anyway.