Use LocalFileReader in FileSystemURLRequestJob

Use LocalFileReader in FileSystemURLRequestJob

- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring

BUG=113300, 114999
TEST=FileSystemURLRequestJobTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132134

[adamk, 2012-04-12 16:04:15]

lgtm with a few nits to fix before submission.

Nice cleanup!

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader.h
File webkit/blob/local_file_reader.h (right):

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader....
webkit/blob/local_file_reader.h:37: // should start.  If the given offset is out
of the file ragnge any
Typo: s/ragnge/range/

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader....
webkit/blob/local_file_reader.h:38: // succeeding read operation may error out
with
"succeeding" is confusing in context, I think you can just leave it out and the
comment still makes sense.

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
File webkit/fileapi/file_system_url_request_job.cc (left):

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
webkit/fileapi/file_system_url_request_job.cc:7: #include <vector>
Why remove this? It's still referenced in this file.

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
webkit/fileapi/file_system_url_request_job.cc:152: if (ranges.size() == 1) {
Nit: I think the Chromium style is to leave these in, even though in WebKit code
we'd remove 'em. Might as well leave them anyway since you're not touching this
code.

[michaeln, 2012-04-12 18:39:58]

lgtm2 :)

[kinuko, 2012-04-13 03:06:28]

Thanks, addressed comments.  Submitting this...

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader.h
File webkit/blob/local_file_reader.h (right):

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader....
webkit/blob/local_file_reader.h:37: // should start.  If the given offset is out
of the file ragnge any
On 2012/04/12 16:04:15, adamk wrote:
> Typo: s/ragnge/range/

Done.

http://codereview.chromium.org/10065011/diff/1/webkit/blob/local_file_reader....
webkit/blob/local_file_reader.h:38: // succeeding read operation may error out
with
On 2012/04/12 16:04:15, adamk wrote:
> "succeeding" is confusing in context, I think you can just leave it out and
the
> comment still makes sense.

Done.

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
File webkit/fileapi/file_system_url_request_job.cc (left):

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
webkit/fileapi/file_system_url_request_job.cc:7: #include <vector>
On 2012/04/12 16:04:15, adamk wrote:
> Why remove this? It's still referenced in this file.

Done.

http://codereview.chromium.org/10065011/diff/1/webkit/fileapi/file_system_url...
webkit/fileapi/file_system_url_request_job.cc:152: if (ranges.size() == 1) {
On 2012/04/12 16:04:15, adamk wrote:
> Nit: I think the Chromium style is to leave these in, even though in WebKit
code
> we'd remove 'em. Might as well leave them anyway since you're not touching
this
> code.

Done.