Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10056001: chromeos: Remove old status-area related code. (Closed)

Created:
8 years, 8 months ago by sadrul
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, zork+watch_chromium.org, sadrul, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

chromeos: Remove old status-area related code. This removes --disable-ash-uber-tray from command-line and chrome://flags, and much of the code that becomes extinct because of this. BUG=122295 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131801

Patch Set 1 #

Patch Set 2 : fix-tests #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -5361 lines) Patch
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 1 chunk +49 lines, -61 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/status_area/status_area_view.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/status_area/status_area_view.cc View 1 5 chunks +12 lines, -15 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_ash.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 3 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 2 chunks +107 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 7 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 7 chunks +1 line, -38 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 9 chunks +1 line, -105 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 4 chunks +0 lines, -19 lines 0 comments Download
D chrome/browser/chromeos/status/accessibility_menu_button.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/chromeos/status/accessibility_menu_button.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/chromeos/status/caps_lock_menu_button.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/chromeos/status/caps_lock_menu_button.cc View 1 chunk +0 lines, -291 lines 0 comments Download
D chrome/browser/chromeos/status/clock_menu_button.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/status/clock_menu_button.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/chromeos/status/clock_updater.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/chromeos/status/clock_updater.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 3 chunks +6 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/status/input_method_menu.h View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/chromeos/status/input_method_menu.cc View 1 chunk +0 lines, -537 lines 0 comments Download
D chrome/browser/chromeos/status/input_method_menu_button.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/chromeos/status/input_method_menu_button.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/chromeos/status/input_method_menu_unittest.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/chromeos/status/memory_menu_button.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/chromeos/status/memory_menu_button.cc View 1 chunk +0 lines, -282 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 7 chunks +29 lines, -75 lines 0 comments Download
D chrome/browser/chromeos/status/network_menu_button.h View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/chromeos/status/network_menu_button.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/chromeos/status/power_menu_button.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/chromeos/status/power_menu_button.cc View 1 chunk +0 lines, -384 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_bubble.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_bubble.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_button.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_button.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_view.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_view.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_view_chromeos.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/chromeos/status/status_area_view_chromeos.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/chromeos/status/volume_menu_button.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/status/volume_menu_button.cc View 1 chunk +0 lines, -265 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.h View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 2 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/ui/views/ash/status_area_host_aura.h View 1 2 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/views/ash/status_area_host_aura.cc View 1 2 1 chunk +0 lines, -230 lines 0 comments Download
D chrome/browser/ui/views/ash/status_area_host_aura_browsertest.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
Hi! Sorry about the large CL, but most of it is removing code no longer ...
8 years, 8 months ago (2012-04-11 06:23:27 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-11 16:03:54 UTC) #2
Ben Goodger (Google)
8 years, 8 months ago (2012-04-11 17:25:41 UTC) #3 
sweet!

On Wed, Apr 11, 2012 at 9:03 AM, <sky@chromium.org> wrote:

> LGTM
>
>
http://codereview.chromium.**org/10056001/<http://codereview.chromium.org/100...
>

Powered by Google App Engine
This is Rietveld 408576698