Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 10054011: Send kStopMark from AudioOutputController to stop AudioThread in renderer (Closed)

Created:
8 years, 8 months ago by vrk (LEFT CHROMIUM)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Send kStopMark from AudioOutputController to stop AudioThread in renderer This is an M18-specific hack in the same vein as kPauseMark that will force the AudioThread to stop listening on the socket for new values. There is no chance that the socket will be in the middle of a read or write, so it should Close() successfully without hanging. BUG=121141 TEST=NONE

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/renderer/media/audio_device.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/audio/audio_output_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vrk (LEFT CHROMIUM)
This should fix things, but since I cannot repro this is untested!
8 years, 8 months ago (2012-04-11 16:37:52 UTC) #1
tommi (sloooow) - chröme
lgtm! thanks for working on this :)
8 years, 8 months ago (2012-04-11 16:48:10 UTC) #2
scherkus (not reviewing)
cool! I think the only remaining task is to figure out a way to verify ...
8 years, 8 months ago (2012-04-11 20:18:18 UTC) #3
vrk (LEFT CHROMIUM)
Closing CL -- won't be committing this! Also if you're curious, the hacky code above ...
8 years, 8 months ago (2012-04-12 17:38:39 UTC) #4
tommi (sloooow) - chröme
8 years, 8 months ago (2012-04-12 17:53:54 UTC) #5
great.  thanks for the update.

On Thu, Apr 12, 2012 at 7:38 PM, <vrk@chromium.org> wrote:

> Closing CL -- won't be committing this!
>
> Also if you're curious, the hacky code above didn't work because there was
> some
> additional weirdness going on with IPC and closing the stream! I didn't
> look
> into it too closely but my sense was fixing the IPC stuff with hacks would
> be a
> much trickier/riskier change -- glad we are going the route of rolling
> forward
> instead :)
>
>
https://chromiumcodereview.**appspot.com/10054011/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698