Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 10054009: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed: (Closed)

Created:
8 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed: - if value is a result of integer32 to double conversion (can't be NaN); - if value was loaded from fast double backing store (already canonicalized). R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-11 12:14:51 UTC) #1
danno
8 years, 8 months ago (2012-04-11 12:26:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698