Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 10054009: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed: (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2072 matching lines...) Expand 10 before | Expand all | Expand 10 after
2083 visited->Add(id()); 2083 visited->Add(id());
2084 // Propagate to the left argument. If the left argument cannot be -0, then 2084 // Propagate to the left argument. If the left argument cannot be -0, then
2085 // the result of the sub operation cannot be either. 2085 // the result of the sub operation cannot be either.
2086 if (range() == NULL || range()->CanBeMinusZero()) { 2086 if (range() == NULL || range()->CanBeMinusZero()) {
2087 return left(); 2087 return left();
2088 } 2088 }
2089 return NULL; 2089 return NULL;
2090 } 2090 }
2091 2091
2092 2092
2093 bool HStoreKeyedFastDoubleElement::NeedsCanonicalization() {
2094 // If value was loaded from unboxed double backing store or
2095 // converted from an integer then we don't have to canonicalize it.
2096 if (value()->IsLoadKeyedFastDoubleElement() ||
2097 (value()->IsChange() && HChange::cast(value())->from().IsInteger32())) {
2098 return false;
2099 }
2100 return true;
2101 }
2102
2103
2093 #define H_CONSTANT_INT32(val) \ 2104 #define H_CONSTANT_INT32(val) \
2094 new(zone) HConstant(FACTORY->NewNumberFromInt(val, TENURED), \ 2105 new(zone) HConstant(FACTORY->NewNumberFromInt(val, TENURED), \
2095 Representation::Integer32()) 2106 Representation::Integer32())
2096 #define H_CONSTANT_DOUBLE(val) \ 2107 #define H_CONSTANT_DOUBLE(val) \
2097 new(zone) HConstant(FACTORY->NewNumber(val, TENURED), \ 2108 new(zone) HConstant(FACTORY->NewNumber(val, TENURED), \
2098 Representation::Double()) 2109 Representation::Double())
2099 2110
2100 #define DEFINE_NEW_H_SIMPLE_ARITHMETIC_INSTR(HInstr, op) \ 2111 #define DEFINE_NEW_H_SIMPLE_ARITHMETIC_INSTR(HInstr, op) \
2101 HInstruction* HInstr::New##HInstr(Zone* zone, \ 2112 HInstruction* HInstr::New##HInstr(Zone* zone, \
2102 HValue* context, \ 2113 HValue* context, \
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
2338 2349
2339 2350
2340 void HCheckPrototypeMaps::Verify() { 2351 void HCheckPrototypeMaps::Verify() {
2341 HInstruction::Verify(); 2352 HInstruction::Verify();
2342 ASSERT(HasNoUses()); 2353 ASSERT(HasNoUses());
2343 } 2354 }
2344 2355
2345 #endif 2356 #endif
2346 2357
2347 } } // namespace v8::internal 2358 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698