Implemented port filter for URLMatcher

Implemented port filter for URLMatcher

This CL implements a port filter for the URLMatcher so that it can now filter by all URL fragments except for the #ref-part.

BUG=112155
TEST=no

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132019

[battre, 2012-04-12 01:03:55]

Please review. Thank you.

Dominic

[Matt Perry, 2012-04-12 01:17:52]

lgtm

https://chromiumcodereview.appspot.com/10052035/diff/1/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc
(right):

https://chromiumcodereview.appspot.com/10052035/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc:294:
if (entry->IsType(Value::TYPE_INTEGER)) {
you could simplify this to:
int int_value;
ListValue* list_value;
if (entry->GetAsInteger(&int_value)) {
  ...
} else if (entry->GetAsList(&list_value))
  ...

[battre, 2012-04-12 06:47:29]

http://codereview.chromium.org/10052035/diff/1/chrome/browser/extensions/api/...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc
(right):

http://codereview.chromium.org/10052035/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc:294:
if (entry->IsType(Value::TYPE_INTEGER)) {
On 2012/04/12 01:17:52, Matt Perry wrote:
> you could simplify this to:
> int int_value;
> ListValue* list_value;
> if (entry->GetAsInteger(&int_value)) {
>   ...
> } else if (entry->GetAsList(&list_value))
>   ...

Done.