Socket.available should never return a negative value.

runtime/bin/socket.cc

Index: runtime/bin/socket.cc
diff --git a/runtime/bin/socket.cc b/runtime/bin/socket.cc
index 9507613333ce2575e06e31dd206e63d9cef59be7..cdc2dd684bbb67d4a3d5c6a139e626ac5fba46da 100644
--- a/runtime/bin/socket.cc
+++ b/runtime/bin/socket.cc
@@ -39,6 +39,8 @@ void FUNCTION_NAME(Socket_Available)(Dart_NativeArguments args) {
   int64_t socket = DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                               DartUtils::kIdFieldName);
   intptr_t available = Socket::Available(socket);
+  // TODO(ajohnsen): Consider if we need to queue a calblack for onError.
+  if (available < 0) available = 0;

[Mads Ager (google), 2012/04/11 07:20:23]

I think we need to handle this differently. An error occurred if available is
less than 0. How about getting the OS error and propagating that to the dart
code in socket_impl.dart. If we get an OSError object back we report that error
on the socket error handler and return 0 from available?

[Anders Johnsen, 2012/04/11 07:25:06]

Agreed, this is a lot better. I've updated as suggested.

   Dart_SetReturnValue(args, Dart_NewInteger(available));
   Dart_ExitScope();
 }