Socket.available should never return a negative value.

runtime/bin/socket.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
 #include "platform/globals.h"
@@ skipping 21 matching lines @@
   }
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_Available)(Dart_NativeArguments args) {
   Dart_EnterScope();
   int64_t socket = DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                               DartUtils::kIdFieldName);
   intptr_t available = Socket::Available(socket);
+  // TODO(ajohnsen): Consider if we need to queue a calblack for onError.
+  if (available < 0) available = 0;

[Mads Ager (google), 2012/04/11 07:20:23]

I think we need to handle this differently. An error occurred if available is
less than 0. How about getting the OS error and propagating that to the dart
code in socket_impl.dart. If we get an OSError object back we report that error
on the socket error handler and return 0 from available?

[Anders Johnsen, 2012/04/11 07:25:06]

Agreed, this is a lot better. I've updated as suggested.

   Dart_SetReturnValue(args, Dart_NewInteger(available));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_ReadList)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t socket =
       DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                  DartUtils::kIdFieldName);
@@ skipping 261 matching lines @@
   Dart_EnterScope();
   Dart_SetReturnValue(args, Dart_Null());
   Dart_Port service_port = Socket::GetServicePort();
   if (service_port != kIllegalPort) {
     // Return a send port for the service port.
     Dart_Handle send_port = Dart_NewSendPort(service_port);
     Dart_SetReturnValue(args, send_port);
   }
   Dart_ExitScope();
 }