Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: chrome/test/data/History/Favicons.v8.sql

Issue 1004373002: Add last_requested field to the favicon_bitmaps table of the favicons database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/History/Favicons.v8.sql
diff --git a/chrome/test/data/History/Favicons.v7.sql b/chrome/test/data/History/Favicons.v8.sql
similarity index 83%
copy from chrome/test/data/History/Favicons.v7.sql
copy to chrome/test/data/History/Favicons.v8.sql
index 8b0fd2c220e4ae2136663b841b94330fa84cdb59..897aade210283d2a9ef9fbf398ee918d6dfba6bb 100644
--- a/chrome/test/data/History/Favicons.v7.sql
+++ b/chrome/test/data/History/Favicons.v8.sql
@@ -1,18 +1,18 @@
--- unit_tests --gtest_filter=ThumbnailDatabaseTest.Version7
+-- unit_tests --gtest_filter=ThumbnailDatabaseTest.Version8
--
--- .dump of a version 7 Favicons database.
+-- .dump of a version 8 Favicons database.
BEGIN TRANSACTION;
CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR);
-INSERT INTO "meta" VALUES('version','7');
+INSERT INTO "meta" VALUES('version','8');
INSERT INTO "meta" VALUES('last_compatible_version','7');
CREATE TABLE favicons(id INTEGER PRIMARY KEY,url LONGVARCHAR NOT NULL,icon_type INTEGER DEFAULT 1);
INSERT INTO "favicons" VALUES(1,'http://www.google.com/favicon.ico',1);
INSERT INTO "favicons" VALUES(2,'http://www.google.com/touch.ico',2);
INSERT INTO "favicons" VALUES(3,'http://www.yahoo.com/favicon.ico',1);
-CREATE TABLE favicon_bitmaps(id INTEGER PRIMARY KEY,icon_id INTEGER NOT NULL,last_updated INTEGER DEFAULT 0,image_data BLOB,width INTEGER DEFAULT 0,height INTEGER DEFAULT 0);
-INSERT INTO "favicon_bitmaps" VALUES(1,1,1287424416,X'313233343631303233353631323033393437353136333435313635393133343837313034373831323336343931363534313932333435313932333435313233343931333400',32,32);
-INSERT INTO "favicon_bitmaps" VALUES(2,2,1287424428,X'676F6977756567727172636F6D697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E616378616E65766961777274786379776867656600',32,32);
-INSERT INTO "favicon_bitmaps" VALUES(3,3,1287424428,X'676F6977756567727172636F6D697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E616378616E65766961777274786379776867656600',32,32);
+CREATE TABLE favicon_bitmaps(id INTEGER PRIMARY KEY,icon_id INTEGER NOT NULL,last_updated INTEGER DEFAULT 0, image_data BLOB,width INTEGER DEFAULT 0,height INTEGER DEFAULT 0,last_requested INTEGER DEFAULT 0);
huangs 2015/03/19 19:14:11 NIT: extra space before comma.
Roger McFarlane (Chromium) 2015/03/20 14:40:59 Done.
+INSERT INTO "favicon_bitmaps" VALUES(1,1,1287424416,X'313233343631303233353631323033393437353136333435313635393133343837313034373831323336343931363534313932333435313932333435313233343931333400',32,32, 0);
huangs 2015/03/19 19:14:11 NIT: same.
Roger McFarlane (Chromium) 2015/03/20 14:40:59 Done.
+INSERT INTO "favicon_bitmaps" VALUES(2,2,1287424428,X'676F6977756567727172636F6D697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E616378616E65766961777274786379776867656600',32,32,1387424428);
+INSERT INTO "favicon_bitmaps" VALUES(3,3,1287424428,X'676F6977756567727172636F6D697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E616378616E65766961777274786379776867656600',32,32,0);
CREATE TABLE icon_mapping(id INTEGER PRIMARY KEY,page_url LONGVARCHAR NOT NULL,icon_id INTEGER);
INSERT INTO "icon_mapping" VALUES(1,'http://google.com/',1);
INSERT INTO "icon_mapping" VALUES(2,'http://www.google.com/',1);

Powered by Google App Engine
This is Rietveld 408576698