chrome/test/data/History/Favicons.v8.sql - Issue 1004373002: Add last_requested field to the favicon_bitmaps table of the favicons database.

Side by Side Diff: chrome/test/data/History/Favicons.v8.sql

Issue 1004373002: Add last_requested field to the favicon_bitmaps table of the favicons database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/history/thumbnail_database_unittest.cc ('K') | « chrome/browser/history/thumbnail_database_unittest.cc ('k') | components/history/core/browser/thumbnail_database.h » ('j') | components/history/core/browser/thumbnail_database.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 -- unit_tests --gtest_filter=ThumbnailDatabaseTest.Version7	1 -- unit_tests --gtest_filter=ThumbnailDatabaseTest.Version8

2 --	2 --

3 -- .dump of a version 7 Favicons database.	3 -- .dump of a version 8 Favicons database.

4 BEGIN TRANSACTION;	4 BEGIN TRANSACTION;

5 CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR );	5 CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR );

6 INSERT INTO "meta" VALUES('version','7');	6 INSERT INTO "meta" VALUES('version','8');

7 INSERT INTO "meta" VALUES('last_compatible_version','7');	7 INSERT INTO "meta" VALUES('last_compatible_version','7');

8 CREATE TABLE favicons(id INTEGER PRIMARY KEY,url LONGVARCHAR NOT NULL,icon_type INTEGER DEFAULT 1);	8 CREATE TABLE favicons(id INTEGER PRIMARY KEY,url LONGVARCHAR NOT NULL,icon_type INTEGER DEFAULT 1);

9 INSERT INTO "favicons" VALUES(1,'http://www.google.com/favicon.ico',1);	9 INSERT INTO "favicons" VALUES(1,'http://www.google.com/favicon.ico',1);

10 INSERT INTO "favicons" VALUES(2,'http://www.google.com/touch.ico',2);	10 INSERT INTO "favicons" VALUES(2,'http://www.google.com/touch.ico',2);

11 INSERT INTO "favicons" VALUES(3,'http://www.yahoo.com/favicon.ico',1);	11 INSERT INTO "favicons" VALUES(3,'http://www.yahoo.com/favicon.ico',1);

12 CREATE TABLE favicon_bitmaps(id INTEGER PRIMARY KEY,icon_id INTEGER NOT NULL,las t_updated INTEGER DEFAULT 0,image_data BLOB,width INTEGER DEFAULT 0,height INTEG ER DEFAULT 0);	12 CREATE TABLE favicon_bitmaps(id INTEGER PRIMARY KEY,icon_id INTEGER NOT NULL,las t_updated INTEGER DEFAULT 0, image_data BLOB,width INTEGER DEFAULT 0,height INTE GER DEFAULT 0,last_requested INTEGER DEFAULT 0);
	huangs 2015/03/19 19:14:11 NIT: extra space before comma. NIT: extra space before comma. Roger McFarlane (Chromium) 2015/03/20 14:40:59 Done. Show quoted text On 2015/03/19 19:14:11, huangs wrote: > NIT: extra space before comma. Done.
13 INSERT INTO "favicon_bitmaps" VALUES(1,1,1287424416,X'31323334363130323335363132 30333934373531363334353136353931333438373130343738313233363439313635343139323334 35313932333435313233343931333400',32,32);	13 INSERT INTO "favicon_bitmaps" VALUES(1,1,1287424416,X'31323334363130323335363132 30333934373531363334353136353931333438373130343738313233363439313635343139323334 35313932333435313233343931333400',32,32, 0);
	huangs 2015/03/19 19:14:11 NIT: same. NIT: same. Roger McFarlane (Chromium) 2015/03/20 14:40:59 Done. Show quoted text On 2015/03/19 19:14:11, huangs wrote: > NIT: same. Done.
14 INSERT INTO "favicon_bitmaps" VALUES(2,2,1287424428,X'676F6977756567727172636F6D 697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E61 6378616E65766961777274786379776867656600',32,32);	14 INSERT INTO "favicon_bitmaps" VALUES(2,2,1287424428,X'676F6977756567727172636F6D 697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E61 6378616E65766961777274786379776867656600',32,32,1387424428);

15 INSERT INTO "favicon_bitmaps" VALUES(3,3,1287424428,X'676F6977756567727172636F6D 697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E61 6378616E65766961777274786379776867656600',32,32);	15 INSERT INTO "favicon_bitmaps" VALUES(3,3,1287424428,X'676F6977756567727172636F6D 697A71797A6B6A616C697462616878666A7974727176707165726F6963786D6E6C6B686C7A756E61 6378616E65766961777274786379776867656600',32,32,0);

16 CREATE TABLE icon_mapping(id INTEGER PRIMARY KEY,page_url LONGVARCHAR NOT NULL,i con_id INTEGER);	16 CREATE TABLE icon_mapping(id INTEGER PRIMARY KEY,page_url LONGVARCHAR NOT NULL,i con_id INTEGER);

17 INSERT INTO "icon_mapping" VALUES(1,'http://google.com/',1);	17 INSERT INTO "icon_mapping" VALUES(1,'http://google.com/',1);

18 INSERT INTO "icon_mapping" VALUES(2,'http://www.google.com/',1);	18 INSERT INTO "icon_mapping" VALUES(2,'http://www.google.com/',1);

19 INSERT INTO "icon_mapping" VALUES(3,'http://www.google.com/',2);	19 INSERT INTO "icon_mapping" VALUES(3,'http://www.google.com/',2);

20 INSERT INTO "icon_mapping" VALUES(4,'http://yahoo.com/',3);	20 INSERT INTO "icon_mapping" VALUES(4,'http://yahoo.com/',3);

21 INSERT INTO "icon_mapping" VALUES(5,'http://www.yahoo.com/',3);	21 INSERT INTO "icon_mapping" VALUES(5,'http://www.yahoo.com/',3);

22 CREATE INDEX favicons_url ON favicons(url);	22 CREATE INDEX favicons_url ON favicons(url);

23 CREATE INDEX favicon_bitmaps_icon_id ON favicon_bitmaps(icon_id);	23 CREATE INDEX favicon_bitmaps_icon_id ON favicon_bitmaps(icon_id);

24 CREATE INDEX icon_mapping_page_url_idx ON icon_mapping(page_url);	24 CREATE INDEX icon_mapping_page_url_idx ON icon_mapping(page_url);

25 CREATE INDEX icon_mapping_icon_id_idx ON icon_mapping(icon_id);	25 CREATE INDEX icon_mapping_icon_id_idx ON icon_mapping(icon_id);

26 COMMIT;	26 COMMIT;

OLD	NEW