Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10041033: Improve tracer output for bailouts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/tracer.dart
diff --git a/lib/compiler/implementation/ssa/tracer.dart b/lib/compiler/implementation/ssa/tracer.dart
index 971f7d874a188345fde5cf21fccea02bf58bc094..e3709e9e34a8a16f466d15ddf14a5a77bdd7a8e4 100644
--- a/lib/compiler/implementation/ssa/tracer.dart
+++ b/lib/compiler/implementation/ssa/tracer.dart
@@ -415,8 +415,15 @@ class HInstructionStringifier implements HVisitor<String> {
case HType.UNKNOWN: type = 'unknown'; break;
default: unreachable();
}
- String onString = node.isOn ? "on" : "off";
- return "TypeGuard: ${temporaryId(node.inputs[0])} is $type ($onString)";
+ StringBuffer result = new StringBuffer();
+ result.add("TypeGuard(${node.isOn ? "on" : "off"}):");
+ result.add(" ${temporaryId(node.guarded)} is $type");
+ result.add(" env:");
+ List<HInstruction> inputs = node.inputs;
+ for (int i = 0; i < inputs.length - 1; i++) {
+ result.add(" ${temporaryId(inputs[i])}");
+ }
+ return result.toString();
kasperl 2012/04/19 06:45:57 I kind of like doing this in this way: var on
floitsch 2012/04/19 12:06:27 Done.
}
String visitIs(HIs node) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698