Improve tracer output for bailouts.

lib/compiler/implementation/ssa/tracer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('tracer');
 
 #import('dart:io');
 #import('ssa.dart');
 #import('../leg.dart');
 
@@ skipping 397 matching lines @@
       case HType.READABLE_ARRAY: type = "readable_array"; break;
       case HType.BOOLEAN: type = "bool"; break;
       case HType.INTEGER: type = "integer"; break;
       case HType.DOUBLE: type = "double"; break;
       case HType.NUMBER: type = "number"; break;
       case HType.STRING: type = "string"; break;
       case HType.STRING_OR_ARRAY: type = "string_or_array"; break;
       case HType.UNKNOWN: type = 'unknown'; break;
       default: unreachable();
     }
-    String onString = node.isOn ? "on" : "off";
-    return "TypeGuard: ${temporaryId(node.inputs[0])} is $type ($onString)";
+    StringBuffer result = new StringBuffer();
+    result.add("TypeGuard(${node.isOn ? "on" : "off"}):");
+    result.add(" ${temporaryId(node.guarded)} is $type");
+    result.add(" env:");
+    List<HInstruction> inputs = node.inputs;
+    for (int i = 0; i < inputs.length - 1; i++) {
+      result.add(" ${temporaryId(inputs[i])}");
+    }
+    return result.toString();

[kasperl, 2012/04/19 06:45:57]

I kind of like doing this in this way:

   var on = node.isOn ? "on" : "off";
   var id = temporaryId(node.guarded);
   return "TypeGuard($on): $id is $type env: $buffer";

and get rid of the first result.add() calls. WDYT? I think it makes the format
easier to grok.

[floitsch, 2012/04/19 12:06:27]

Done.

   }
 
   String visitIs(HIs node) {
     String type = node.typeName.toString();
     return "TypeTest: ${temporaryId(node.expression)} is $type";
   }
 }