chrome/common/net/gaia/oauth2_mint_token_flow.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/gaia/oauth2_mint_token_flow.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_unpacker_unittest.cc ('k') | chrome/common/net/gaia/oauth2_mint_token_flow_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/net/gaia/oauth2_mint_token_flow.cc

diff --git a/chrome/common/net/gaia/oauth2_mint_token_flow.cc b/chrome/common/net/gaia/oauth2_mint_token_flow.cc

index 0232b92d379ce8fb4fc830e9b2502123eb0dc644..e2010e8b9ec295ca34b02109faa771d2eb4fc661 100644

--- a/chrome/common/net/gaia/oauth2_mint_token_flow.cc

+++ b/chrome/common/net/gaia/oauth2_mint_token_flow.cc

@@ -184,8 +184,7 @@ void OAuth2MintTokenFlow::ProcessApiCallSuccess(

// internal error.

std::string response_body;

source->GetResponseAsString(&response_body);

- base::JSONReader reader;

- scoped_ptr<base::Value> value(reader.Read(response_body, false));

+ scoped_ptr<base::Value> value(base::JSONReader::Read(response_body));

DictionaryValue* dict = NULL;

if (!value.get() || !value->GetAsDictionary(&dict)) {

ReportFailure(GoogleServiceAuthError::FromConnectionError(101));