Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8824)

Unified Diff: chrome/common/extensions/extension_unpacker_unittest.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_unpacker_unittest.cc
diff --git a/chrome/common/extensions/extension_unpacker_unittest.cc b/chrome/common/extensions/extension_unpacker_unittest.cc
index a590b3609c85f7db5a7547a4465a9fb5db89a54a..4c43a7bd59c0d10a757b4e18f99c0b5583e188e6 100644
--- a/chrome/common/extensions/extension_unpacker_unittest.cc
+++ b/chrome/common/extensions/extension_unpacker_unittest.cc
@@ -103,8 +103,8 @@ TEST_F(ExtensionUnpackerTest, MAYBE_InvalidMessagesFile) {
SetupUnpacker("invalid_messages_file.crx");
EXPECT_FALSE(unpacker_->Run());
EXPECT_TRUE(MatchPattern(unpacker_->error_message(),
- ASCIIToUTF16("*_locales?en_US?messages.json: Line: 2, column: 3,"
- " Dictionary keys must be quoted.")));
+ ASCIIToUTF16("*_locales?en_US?messages.json: Line: 2, column: 11,"
+ " Syntax error."))) << unpacker_->error_message();
}
// Crashes intermittently on Vista, see http://crbug.com/109238
« no previous file with comments | « chrome/common/extensions/extension_l10n_util_unittest.cc ('k') | chrome/common/net/gaia/oauth2_mint_token_flow.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698