Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/search_engines/template_url_unittest.cc

Issue 10033017: More misc. cleanups to minimize future refactoring diffs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_unittest.cc
===================================================================
--- chrome/browser/search_engines/template_url_unittest.cc (revision 131375)
+++ chrome/browser/search_engines/template_url_unittest.cc (working copy)
@@ -329,7 +329,7 @@
data.SetURL(test_data[i].url);
TemplateURL url(data);
EXPECT_TRUE(url.url_ref().IsValid());
- EXPECT_TRUE(url.url_ref().SupportsReplacement());
+ ASSERT_TRUE(url.url_ref().SupportsReplacement());
std::string expected_result = test_data[i].expected_result;
ReplaceSubstringsAfterOffset(&expected_result, 0, "{language}",
g_browser_process->GetApplicationLocale());
@@ -369,6 +369,8 @@
data.input_encodings.clear();
data.input_encodings.push_back(test_data[i].encoding);
TemplateURL url(data);
+ EXPECT_TRUE(url.url_ref().IsValid());
+ ASSERT_TRUE(url.url_ref().SupportsReplacement());
GURL result(url.url_ref().ReplaceSearchTerms(test_data[i].search_term,
TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));
ASSERT_TRUE(result.is_valid());
@@ -398,7 +400,7 @@
"{google:originalQueryForSuggestion}q={searchTerms}");
data.input_encodings.push_back("UTF-8");
TemplateURL url(data);
- ASSERT_TRUE(url.url_ref().IsValid());
+ EXPECT_TRUE(url.url_ref().IsValid());
ASSERT_TRUE(url.url_ref().SupportsReplacement());
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
GURL result(url.url_ref().ReplaceSearchTerms(ASCIIToUTF16("foobar"),

Powered by Google App Engine
This is Rietveld 408576698