Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5279)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 10033017: More misc. cleanups to minimize future refactoring diffs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
===================================================================
--- chrome/browser/search_engines/template_url_service_unittest.cc (revision 131375)
+++ chrome/browser/search_engines/template_url_service_unittest.cc (working copy)
@@ -491,6 +491,9 @@
// Make sure we don't get a trailing /
ASSERT_EQ(ASCIIToUTF16("blah"),
TemplateURLService::GenerateKeyword(GURL("http://blah/"), true));
+ // Don't generate the empty string.
+ ASSERT_EQ(ASCIIToUTF16("www"),
+ TemplateURLService::GenerateKeyword(GURL("http://www."), false));
}
TEST_F(TemplateURLServiceTest, GenerateSearchURL) {
@@ -795,11 +798,11 @@
// value are persisted to prefs.
const TemplateURL* default_turl = model()->GetDefaultSearchProvider();
ASSERT_TRUE(default_turl);
- ASSERT_EQ("http://url", default_turl->url());
- ASSERT_EQ("http://url2", default_turl->suggestions_url());
+ EXPECT_EQ(ASCIIToUTF16("a"), default_turl->short_name());
+ EXPECT_EQ("http://url", default_turl->url());
+ EXPECT_EQ("http://url2", default_turl->suggestions_url());
EXPECT_EQ("http://instant", default_turl->instant_url());
- ASSERT_EQ(ASCIIToUTF16("a"), default_turl->short_name());
- ASSERT_EQ(id, default_turl->id());
+ EXPECT_EQ(id, default_turl->id());
// Now do a load and make sure the default search provider really takes.
test_util_.VerifyLoad();

Powered by Google App Engine
This is Rietveld 408576698