Issue 10025040: Use interpolation instead of concatenation.

Issue 10025040: Use interpolation instead of concatenation. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov, hausner

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Use interpolation instead of concatenation. Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=422

Patch Set 1 #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	LayoutTests/dart/Window-postMessage.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/dart/dart-imports-main.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/dart/fib.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/dart/fib.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/dart/security/cross-frame-access.html	View	1 chunk	+1 line, -1 line	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/security/cross-frame-access.html File LayoutTests/dart/security/cross-frame-access.html (right): https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/security/cross-frame-access.html#newcode103 LayoutTests/dart/security/cross-frame-access.html:103: location.href = 'data:text/html, <script>parent.postMessage("navigated", "*")<${"/script>"}'; Am I missing ...

8 years, 8 months ago (2012-04-19 17:19:46 UTC) #3

Anton Muhin

https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/security/cross-frame-access.html File LayoutTests/dart/security/cross-frame-access.html (right): https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/security/cross-frame-access.html#newcode103 LayoutTests/dart/security/cross-frame-access.html:103: location.href = 'data:text/html, <script>parent.postMessage("navigated", "*")<${"/script>"}'; Almost---this code is embedded ...

8 years, 8 months ago (2012-04-19 17:20:44 UTC) #4

hausner

8 years, 8 months ago (2012-04-19 17:22:09 UTC) #5

https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/secur...
File LayoutTests/dart/security/cross-frame-access.html (right):

https://chromiumcodereview.appspot.com/10025040/diff/1/LayoutTests/dart/secur...
LayoutTests/dart/security/cross-frame-access.html:103: location.href =
'data:text/html, <script>parent.postMessage("navigated", "*")<${"/script>"}';
Ah, so I was missing something :) Thanks for the explanation!

On 2012/04/19 17:20:44, antonmuhin wrote:
> Almost---this code is embedded into HTML, so if I leave it as </script> HTML
> parser will be surprised :)
> 
> On 2012/04/19 17:19:46, hausner wrote:
> > Am I missing something or are you simply interpolating a string literal
inside
> a
> > string literal?
> > 
> > '..... ${"bla"}'  is the same as  '..... bla' 
> > 
>

Expand Messages | Collapse Messages