src/trusted/validator/validation_cache_test.cc - Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/validation_cache_test.cc

Issue 10024039: Replace kind variable from validator API with Boolean stubout parameter. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/ncvalidate.h ('K') | « src/trusted/validator/ncvalidate.h ('k') | src/trusted/validator/x86/32/ncvalidate.c » ('j') | src/trusted/validator_x86/ncenuminsts_x86_32.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/validation_cache_test.cc

diff --git a/src/trusted/validator/validation_cache_test.cc b/src/trusted/validator/validation_cache_test.cc

index c7eb416e05821216bc023cb4227df58c43987efc..9a8124701e482b578501644b42a6b2b765900c84 100644

--- a/src/trusted/validator/validation_cache_test.cc

+++ b/src/trusted/validator/validation_cache_test.cc

@@ -134,9 +134,8 @@ class ValidationCachingInterfaceTests : public ::testing::Test {

NACL_TARGET_ARCH,

NACL_TARGET_SUBARCH)(

NACL_SB_DEFAULT,

- NaClApplyCodeValidation,

0, code_buffer, 32,

- bundle_size, FALSE, &cpu_features,

+ bundle_size, FALSE, FALSE, &cpu_features,

Mark Seaborn 2012/04/10 00:57:38 Could you add comments for the args here too, perh

Nick Bray (chromium) 2012/04/10 18:49:20 Done.

&cache);

}

};

@@ -156,9 +155,8 @@ TEST_F(ValidationCachingInterfaceTests, NoCache) {

NACL_TARGET_ARCH,

NACL_TARGET_SUBARCH)(

NACL_SB_DEFAULT,

- NaClApplyCodeValidation,

0, code_buffer, CODE_SIZE,

- bundle_size, FALSE, &cpu_features,

+ bundle_size, FALSE, FALSE, &cpu_features,

NULL);

EXPECT_EQ(NaClValidationSucceeded, status);

}